Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Change native frames from traceId to spanId #4029

Merged
merged 3 commits into from
Aug 16, 2024
Merged

ref: Change native frames from traceId to spanId #4029

merged 3 commits into from
Aug 16, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Enhancement
  • Refactoring

📜 Description

This PR changes the native frames from attaching to traceId which can be the same for multiple spans to spanId.

  • This fixes potencial situations when multiple root spans share the same trace id. This is possible since JS v8, before Transaction (now Root Spans) would always have unique trace id.
  • This is needed for attaching the native frames as span level measurements.

💚 How did you test it?

sample app, unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

@krystofwoldrich krystofwoldrich merged commit 4cd26bd into kw/add-tsc-to-tests Aug 16, 2024
88 of 98 checks passed
@krystofwoldrich
Copy link
Member Author

This merge was a mistake from VSCode GH plugin. I'll open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @getsentry-bot